FrSky GPS questions

[sporez]

I just flew with r748 and the GPS alt worked well! I was able to zero it on the rpm screen and it seemed to be showing up correctly. Great work!

[ReSt]

Thanks Mike,
really a good job!

it is now working.

There is one remaining favour
Can you add the maximum altitude display with one of your next updates?

I have a simple solution that does it, but I'm sure you know a more efficient way.
I have marked the lines that need to be changed /added with '//add' or '//replace'
I've put in the surrounding code, so you can easily locate it.

define a variable to hold the value

Code: Select all

int16_t g_chans512[NUM_CHNOUT];

int16_t MaxGpsAlt=0;			//add

extern bool warble;

replace the text to be displayed, save the highest altitude and display it

Code: Select all

                lcd_puts_Pleft( 3*FH, PSTR("Lon=")) ;
                lcd_outdezNAtt(8*FW, 3*FH, FrskyHubData[18], LEADING0 | blink, -5);
                lcd_putc(8*FW, 3*FH, '.') ;
                lcd_outdezNAtt(12*FW, 3*FH, FrskyHubData[26], LEADING0 | blink, -4);

//            lcd_puts_Pleft( 4*FH, Str_ALTeq ) ;                      // replace with next line
               lcd_puts_Pleft( 4*FH, PSTR("Alt=\011m   Max=")) ;       // replaces previous line
                   lcd_outdezAtt(8 * FW, 4*FH, FrskyHubData[1], 0 ) ;  // add

                
		  lcd_puts_Pleft( 5*FH, PSTR("Spd=\011kts Max=")) ;
                  lcd_outdezAtt(20*FW, 5*FH, MaxGpsSpeed, blink );
              if (frskyUsrStreaming)
			{
                    if ( FrskyHubData[1] > MaxGpsAlt ) MaxGpsAlt = FrskyHubData[1] ;  // add
                    lcd_outdezAtt(20*FW, 4*FH, MaxGpsAlt, 0);              // add

            	    lcd_outdezAtt(8*FW, 5*FH, FrskyHubData[17], 0);

                      lcd_puts_Pleft( 6*FH, PSTR("V1=\007V2=\016V3=")) ;

Reinhard

[MikeB]

I've put this in my todo list. I must find a bit of time to see what else is in there!

Mike.

[MikeB]

OK, this is going in, I'm putting the test for setting the MaxAlt in frsky.cpp, with the test for max speed. That way it will always get updated, even if you have a different screen showing. I've also added menu[long] resets max speed and max altitude to zero.

Not sure when I'll commit this, looking at one or two other things as well.

Mike.

[ReSt]

Thanks Mike.

Take you time, I'm not in a hurry.

Reinhard

[ReSt]

Hello Mike,

in the meantime I have modified the menus.cpp file to implement the following changes:

The menu system:
===================

* removed the telemetry screen from the system screens sequence (UP/DOWN[short])

* Enter telemetry screens with DOWN[long] only

* Within telemetry screens, move right/left with RIGHT/LEFT[short/long], do no longer exit to system/configuration screens

* Exit telemetry screens with DOWN[short] to system screens or UP[long] to statistics screens only



On GPS screen:
=============

* display maximum altitude , always in metric units; (as previous change)


On RPM screen:
=============
* display max and home altitude in metric or imperial units

* home and max altitude are only displayed, after home altitude has been set

* MENU[long] = Set and show home and max altitude
(Actual and max altitude are always displayed relative to home altitude)

* MENU[short] = toggle between home altitude and 0.
(home altitude can be switched back and forth with MENU[short] between 0 and the saved home altitude, changing the display between absolute altitude and relative to home altitude.)

* EXIT = reset and hide home and max altitude display

* Maximum altitude value is synchronized in both screens (RPM and GPS)


I'm attaching the files.
Please have a look into them, I have marked all lines (see r753 altitude mod.txt) that have been modified.
BUT I'm no C++ programmer (more copy and paste).

Use whatever you think is worth to be used.

Reinhard

[MikeB]

Thanks I'll have a look.

Mike.