ERSKY9X Coding

erskyTx runs on many radios and upgrade boards
ersky9x was a port of er9x for use on the sky9x board.
User avatar
jhsa
Posts: 19480
Joined: Tue Dec 27, 2011 5:13 pm
Country: Germany

Re: ERSKY9X Coding

Post by jhsa »

we understand how it works Mike :) We, or at least I was asking if it could show something different. For others that don't follow the development, that will be confusing because they will expect it to work differently. This was the reason I asked ;)

João
My er9x/Ersky9x/eepskye Video Tutorials
https://www.youtube.com/playlist?list=PL5uJhoD7sAKidZmkhMpYpp_qcuIqJXhb9

Donate to Er9x/Ersky9x:
https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=YHX43JR3J7XGW

User avatar
MikeB
9x Developer
Posts: 17990
Joined: Tue Dec 27, 2011 1:24 pm
Country: -
Location: Poole, Dorset, UK

Re: ERSKY9X Coding

Post by MikeB »

As I understand it, you are asking for the weight to NOT be bold if the source is a 2-pos switch that is OFF.
My point is the mix output will be -100% in this situation, which is different from having a mix controlled by a switch, and that switch is off.

Mike.
erskyTx/er9x developer
The difficult we do immediately,
The impossible takes a little longer!
ReSt
Posts: 1581
Joined: Tue Dec 27, 2011 11:34 pm
Country: -

Re: ERSKY9X Coding

Post by ReSt »

I understand and accept, that the weight has to be in bold, independent of the position of the switch.
But would it then be possible to have the switch showing its state with bold or normal ?

Reinhard
User avatar
jhsa
Posts: 19480
Joined: Tue Dec 27, 2011 5:13 pm
Country: Germany

Re: ERSKY9X Coding

Post by jhsa »

That's an idea.. :) But what about the 3 position switches? ;)

João
My er9x/Ersky9x/eepskye Video Tutorials
https://www.youtube.com/playlist?list=PL5uJhoD7sAKidZmkhMpYpp_qcuIqJXhb9

Donate to Er9x/Ersky9x:
https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=YHX43JR3J7XGW
ReSt
Posts: 1581
Joined: Tue Dec 27, 2011 11:34 pm
Country: -

Re: ERSKY9X Coding

Post by ReSt »

for 3 and more positions there will always be one position active at a time; so displaying it in one single line it will always be active.
No chance to show the status in a single line with bold/normal.

Basic Question:
Isn't the effect of a switch as source the same as Full + a switch ?

So, is the switch as source really required or simply another (somewhat irritating) method of doing the same?
I see, switch as source allows immediately an additional switch as a condition (but for the price that you don't have the indication of the source switches state)

Contrary, with full and a switch you had to use a logical switch that combines the switches

Reinhard

User avatar
jhsa
Posts: 19480
Joined: Tue Dec 27, 2011 5:13 pm
Country: Germany

Re: ERSKY9X Coding

Post by jhsa »

Yeah, we can combine 2 switches in a mix. :)

João

Sent from my thor using Tapatalk

My er9x/Ersky9x/eepskye Video Tutorials
https://www.youtube.com/playlist?list=PL5uJhoD7sAKidZmkhMpYpp_qcuIqJXhb9

Donate to Er9x/Ersky9x:
https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=YHX43JR3J7XGW
User avatar
MikeB
9x Developer
Posts: 17990
Joined: Tue Dec 27, 2011 1:24 pm
Country: -
Location: Poole, Dorset, UK

Re: ERSKY9X Coding

Post by MikeB »

ReSt wrote: Fri Aug 25, 2017 7:48 amBasic Question:
Isn't the effect of a switch as source the same as Full + a switch ?
Yes, for a 2-position switch, which is why I mentioned a few post back that it is FULL (and HALF) that are the odd ones and could be removed.
With sources other than FULL and HALF, a switch enables/disables a mix. With FULL/HALF the switch controls the output. They have special processing in the mixer. (I'm not intending to remove them however).

I have a source code change in where a mix with either FULL or HALF as the source will show as always active, since they are always active.

Mike.
erskyTx/er9x developer
The difficult we do immediately,
The impossible takes a little longer!
User avatar
jhsa
Posts: 19480
Joined: Tue Dec 27, 2011 5:13 pm
Country: Germany

Re: ERSKY9X Coding

Post by jhsa »

Mike, please don't remove them. Remember I said before that there are some situations that seem to not work if we use a switch as source and do work with FULL and HALF?

Well, yesterday while trying to help someone I think I found one of those. Please let me try replicating it in a while and post it here. Maybe I was doing something wrong, but I don't think so..

Thanks

João

Sent from my thor using Tapatalk

My er9x/Ersky9x/eepskye Video Tutorials
https://www.youtube.com/playlist?list=PL5uJhoD7sAKidZmkhMpYpp_qcuIqJXhb9

Donate to Er9x/Ersky9x:
https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=YHX43JR3J7XGW
User avatar
jhsa
Posts: 19480
Joined: Tue Dec 27, 2011 5:13 pm
Country: Germany

Re: ERSKY9X Coding

Post by jhsa »

Ok.. Here:

Ch3 100% Thr
__R 100% CH3 Switch (GEA)

Ch7 100% Thr Switch (GEA) Curve (x<0)
__R 100% CH7 Switch (!GEA)
__R 0% sTRN

You will never be able to move CH7 unless you use:

R 0% HALF Switch (TRN)

or something like:

R 0% sTRN Switch (TRN) which throws all the purpose of using a switch as source out of the window :)

So, there are situations where the mix has to be "Inactive".
And a replace mix needs ?always? a switch to enable / disable it because otherwise would be always active, and therefore always replacing the ones above, right?

So, if you would decide to remove the other sources, something like "R 0% sTRN Switch (TRN)" would replace "FULL" but I guess you would have still to leave "HALF".

Now two things to consider:
1 - All manuals would be wrong. Not such a big problem ;)
2 - We all would have to redo all the mixes using "FULL"

Thanks

João
My er9x/Ersky9x/eepskye Video Tutorials
https://www.youtube.com/playlist?list=PL5uJhoD7sAKidZmkhMpYpp_qcuIqJXhb9

Donate to Er9x/Ersky9x:
https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=YHX43JR3J7XGW
User avatar
MikeB
9x Developer
Posts: 17990
Joined: Tue Dec 27, 2011 1:24 pm
Country: -
Location: Poole, Dorset, UK

Re: ERSKY9X Coding

Post by MikeB »

Did you miss "(I'm not intending to remove them however)." in my post above?

Mike.
erskyTx/er9x developer
The difficult we do immediately,
The impossible takes a little longer!
User avatar
jhsa
Posts: 19480
Joined: Tue Dec 27, 2011 5:13 pm
Country: Germany

Re: ERSKY9X Coding

Post by jhsa »

MikeB wrote: Fri Aug 25, 2017 8:51 am Yes, for a 2-position switch, which is why I mentioned a few post back that it is FULL (and HALF) that are the odd ones and could be removed.

Mike.
Yes, I have seen it :) But the reason I've posted was because of your statement quoted above. You say they COULD be removed.
My post explains why I think they couldn't ;) Or FULL probably could but it would make the mixer less intuitive :)
Now, there might be something that I didn't understand... it wouldn't be the first time.. or the last. ;)

João
My er9x/Ersky9x/eepskye Video Tutorials
https://www.youtube.com/playlist?list=PL5uJhoD7sAKidZmkhMpYpp_qcuIqJXhb9

Donate to Er9x/Ersky9x:
https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=YHX43JR3J7XGW
ReSt
Posts: 1581
Joined: Tue Dec 27, 2011 11:34 pm
Country: -

Re: ERSKY9X Coding

Post by ReSt »

jhsa wrote: Fri Aug 25, 2017 10:40 am
Ch7 100% Thr Switch (GEA) Curve (x<0)
__R 100% CH7 Switch (!GEA)
__R 0% sTRN

You will never be able to move CH7 unless you use: ......
As a mix with a switch as source is always active, the "replace" option doesn't make sense and it probably should be disabled :?:
The mixer lines above such a line will never influence the result.

Reinhard
User avatar
jhsa
Posts: 19480
Joined: Tue Dec 27, 2011 5:13 pm
Country: Germany

Re: ERSKY9X Coding

Post by jhsa »

Probably not but that line will influence the mixes above, and it needs to have the replace option. If you don't need it just don't use it :) Simple as that.

To make it work like this for example:

R 0% sTRN Switch (TRN)

You need the replace, otherwise it won't work.. Try it on the example above..

João
My er9x/Ersky9x/eepskye Video Tutorials
https://www.youtube.com/playlist?list=PL5uJhoD7sAKidZmkhMpYpp_qcuIqJXhb9

Donate to Er9x/Ersky9x:
https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=YHX43JR3J7XGW
User avatar
MikeB
9x Developer
Posts: 17990
Joined: Tue Dec 27, 2011 1:24 pm
Country: -
Location: Poole, Dorset, UK

Re: ERSKY9X Coding

Post by MikeB »

No, a mix may also be enabled/disabled by choosing which in which flight modes it is active, so having a replace option is still needed.

FULL is not needed, but I agree HALF could still be needed. I'm NOT removing either anyway.

Mike.
erskyTx/er9x developer
The difficult we do immediately,
The impossible takes a little longer!
User avatar
jhsa
Posts: 19480
Joined: Tue Dec 27, 2011 5:13 pm
Country: Germany

Re: ERSKY9X Coding

Post by jhsa »

FULL is not needed when using the same switch also in the switch field, right? Or there is any other reason? Just that I /We understand :)

Thanks

João

EDIT: Ok, answering a bit my question, HALF can be used instead in my example..
My er9x/Ersky9x/eepskye Video Tutorials
https://www.youtube.com/playlist?list=PL5uJhoD7sAKidZmkhMpYpp_qcuIqJXhb9

Donate to Er9x/Ersky9x:
https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=YHX43JR3J7XGW
ReSt
Posts: 1581
Joined: Tue Dec 27, 2011 11:34 pm
Country: -

Re: ERSKY9X Coding

Post by ReSt »

discovered a little bug in the logical switches setup (prov. vers. 3e r221).
All compares, when you scroll through the possible values, show an empty field as the last 'parameter' . Older versions (e.g.C3) did stop on the parameter before.
The other functions like AND, OR ... are ok.

And there is something strange, don't know if that is (part of) a new feature that I don't understand or another bug.
When you scroll down through the list of logic switches (L1, L2, .....LN, LO) the switches continue with, again L1 - LO and a fixed text of Delay and an inputfield that can step up to 3.0

Reinhard
User avatar
jhsa
Posts: 19480
Joined: Tue Dec 27, 2011 5:13 pm
Country: Germany

Re: ERSKY9X Coding

Post by jhsa »

That is the new implementation of a delay function on the logical switches. It is still not ready. Needs more testing..
Please see one of my posts above that explains how to test the new edit menu for the logical switches. You can also test it. They include the delay as well. So when this becomes the default, I believe all the delay switches at the end will be removed.
The new edit menu could allow for more options on the logical switches.
To see the menu, select a logical switch and press left once. The is line will start blinking. Press menu long to enter the edit menu..
This is of course still experimental ;)

João

Sent from my thor using Tapatalk

My er9x/Ersky9x/eepskye Video Tutorials
https://www.youtube.com/playlist?list=PL5uJhoD7sAKidZmkhMpYpp_qcuIqJXhb9

Donate to Er9x/Ersky9x:
https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=YHX43JR3J7XGW
User avatar
MikeB
9x Developer
Posts: 17990
Joined: Tue Dec 27, 2011 1:24 pm
Country: -
Location: Poole, Dorset, UK

Re: ERSKY9X Coding

Post by MikeB »

If you set a value for delay then when a logical switch normally becomes ON, the actual ON detection is delayed by the set amount.

Mike.
erskyTx/er9x developer
The difficult we do immediately,
The impossible takes a little longer!
ReSt
Posts: 1581
Joined: Tue Dec 27, 2011 11:34 pm
Country: -

Re: ERSKY9X Coding

Post by ReSt »

Thank you both for updating me.

I just ran a short test of the menu and it looks good.
The momentary delay is a 'switch ON' delay, how about an additional 'switch OFF' delay ? (I know, Eeprom space :) )

But the menu also shows the above mentioned erratic behaviour.
If you select e.g. v>val and scroll the v1 variables til the end, you get an empty v1 field.
All compare functions scrolls one position to far.

Reinhard
User avatar
MikeB
9x Developer
Posts: 17990
Joined: Tue Dec 27, 2011 1:24 pm
Country: -
Location: Poole, Dorset, UK

Re: ERSKY9X Coding

Post by MikeB »

Not only EEPROM space, but also the code to add the delay to the OFF transisition, and handle the situation where the switch changes state faster than the set delays.

I'll fix the empty field, I wonder when that crept in?

Mike.
erskyTx/er9x developer
The difficult we do immediately,
The impossible takes a little longer!
User avatar
jhsa
Posts: 19480
Joined: Tue Dec 27, 2011 5:13 pm
Country: Germany

Re: ERSKY9X Coding

Post by jhsa »

Mike, In the new LS menu you have
Function
V1
ofs

Shouldn't "ofs" be called "val" instead? The name "ofs" was changed to "val" many moons ago :) :D

João
My er9x/Ersky9x/eepskye Video Tutorials
https://www.youtube.com/playlist?list=PL5uJhoD7sAKidZmkhMpYpp_qcuIqJXhb9

Donate to Er9x/Ersky9x:
https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=YHX43JR3J7XGW
ReSt
Posts: 1581
Joined: Tue Dec 27, 2011 11:34 pm
Country: -

Re: ERSKY9X Coding

Post by ReSt »

it came later than the c5 version. That was still ok

Reinhard
User avatar
MikeB
9x Developer
Posts: 17990
Joined: Tue Dec 27, 2011 1:24 pm
Country: -
Location: Poole, Dorset, UK

Re: ERSKY9X Coding

Post by MikeB »

I've fixed the empty field bug, and also changed "ofs" to "val", in the source code.

Mike.
erskyTx/er9x developer
The difficult we do immediately,
The impossible takes a little longer!
User avatar
jhsa
Posts: 19480
Joined: Tue Dec 27, 2011 5:13 pm
Country: Germany

Re: ERSKY9X Coding

Post by jhsa »

Great, thanks Mike..

João

Sent from my thor using Tapatalk

My er9x/Ersky9x/eepskye Video Tutorials
https://www.youtube.com/playlist?list=PL5uJhoD7sAKidZmkhMpYpp_qcuIqJXhb9

Donate to Er9x/Ersky9x:
https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=YHX43JR3J7XGW
ReSt
Posts: 1581
Joined: Tue Dec 27, 2011 11:34 pm
Country: -

Re: ERSKY9X Coding

Post by ReSt »

I think I found my solution for the Switch as source 'problem' and my AR9X board

The 2-pos (logical and hardware) switches now deliver a value of +100% when active (if 100% weight) and are ignored when inactive.
The weight is shown in bold when the switch is active and normal when inactive
Weight, offset, add, multiply and replace seem to work.
If I don't find a showstopper, I will use this mod that way.

Reinhard

I set a variable when the switch used is a 2-pos switch and according to this var and the 'swon' that gives the state of the switch, I bypass parts of the code when it is a 2-pos switch and it is off.
User avatar
MikeB
9x Developer
Posts: 17990
Joined: Tue Dec 27, 2011 1:24 pm
Country: -
Location: Poole, Dorset, UK

Re: ERSKY9X Coding

Post by MikeB »

Do you mean you have changed the operation of a 2-pos switch as source?
Instead of getting -100% and +100% you are getting 0% and +100% (same effect as using HALF as source and a switch)?

If you set an offset value, don't you get an output from the mix when the switch is off (the offset amount)? If so, then the mix is active.

Mike.
erskyTx/er9x developer
The difficult we do immediately,
The impossible takes a little longer!
ReSt
Posts: 1581
Joined: Tue Dec 27, 2011 11:34 pm
Country: -

Re: ERSKY9X Coding

Post by ReSt »

2-pos hardware and 2-pos logical switch
but if the switch is off, I skip some parts of the code and nothing is added (replaced, multiplied) to the (previous) mix.

Offset to the switch also is active only when the switch is active.

There are some functions that do not work like slow, delay, expo. But I can live without.

Reinhard


scan to "ReSt" to easily locate the modifications
mixer.zip
my mixer.cpp with modifications and compiled firmware for AR9x board
(193.91 KiB) Downloaded 103 times
User avatar
jhsa
Posts: 19480
Joined: Tue Dec 27, 2011 5:13 pm
Country: Germany

Re: ERSKY9X Coding

Post by jhsa »

Hmmm, I'm not sure I understand what is happening :)

João
My er9x/Ersky9x/eepskye Video Tutorials
https://www.youtube.com/playlist?list=PL5uJhoD7sAKidZmkhMpYpp_qcuIqJXhb9

Donate to Er9x/Ersky9x:
https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=YHX43JR3J7XGW
User avatar
MikeB
9x Developer
Posts: 17990
Joined: Tue Dec 27, 2011 1:24 pm
Country: -
Location: Poole, Dorset, UK

Re: ERSKY9X Coding

Post by MikeB »

So, the same effect as setting the source as a switch and using the same switch in the switch field.
I can't see why you need the mod then.
With the mod, you can't then use a 2-pos switch as the source and have -100% and +100% as the mix output unless you use FULL as the source and the switch in the switch field.

Mike.
erskyTx/er9x developer
The difficult we do immediately,
The impossible takes a little longer!
ReSt
Posts: 1581
Joined: Tue Dec 27, 2011 11:34 pm
Country: -

Re: ERSKY9X Coding

Post by ReSt »

Yes, the same effect, but you have one more switch immediately available
And yes, I can not have +100 and -100 at the same time with one switch, when the intention is, that the switch mix line doesn't affect the result, when the switch is inactive

Up to now, a mixline with a switch is ignored and displayed in normal letters, when the switch is inactive .
My modification is intended to exactly do the same, when the source is a switch.

Ignore the line when the switch is inactive and show the weight in normal letters
or
use the line when the switch is active and show the weight in bold letters

The actual code breaks this rule as the switch mix is treated as alway active, independent of the status of the switch.
You no longer see at the mixerline if the SWITCH is active or not and what the MIX does in the moment.

Reinhard

Post Reply

Return to “erskyTx (was ersky9x)”