To build or not to build (with templates that is)

Post by **erazz** » Sat Jan 28, 2012 6:10 pm

Hi Guys,

We gotta cut some fat. The FrSky version has become so large it's taking too much space. I'll be taking the templates off of it to make some space.

That got me thinking...
Does anybody here use the templates? Now that eePe works rather well and we have some sort of template repository, does it really make sense to have templates? I could also get rid of the annoying "RETA" option since it's only used for the templates.

Tell me what you think...

Post by **cre8tiveleo** » Sat Jan 28, 2012 6:36 pm

Lose'm
Templates in eepe make more sense.

Post by **jhsa** » Sat Jan 28, 2012 6:38 pm

RETA is the channel sequence that I use for all my models.. what would it affect if you take it off? I think I don't understand very well wht u mean..

templates can go..

Post by **MikeB** » Sat Jan 28, 2012 6:41 pm

It does save quite a bit of space. The only time I use a template is when I create a new model on the radio. Then I get the default 4 channels, but I do like them to be in the correct order, generally AETR for me. You still need apply_template 'cos it is called from modelDefault(). I did slim this down for the no template option.

Mike.

njozsef · Post by **njozsef** » Sat Jan 28, 2012 6:45 pm

Hi Erazz
I do not need a template. There is the epee.
But the important heli menu.
(makefile)
HELI = YES
TEMPLATES = NO

i probably light on the power on spash screen.
This correct or not? (I am beginner. ((((very beginner))))

Thx
njozsef

from er9x.cpp

Code: Select all

void doSplash()
{
    if(!g_eeGeneral.disableSplashScreen)
    {


<<<<<<< .mine
                               //check_backlight() ;
                              //light on the splash screen (njozsef)	  
                              BACKLIGHT_ON;
        
                              lcd_clear();
=======
                              check_backlight() ;

                              lcd_clear();
>>>>>>> .r688

njozsef · Post by **njozsef** » Sat Jan 28, 2012 8:22 pm

oops.
you think you can do the same.
r689 build this OK.
Ligh on the splash.THX. nj.

Post by **MikeB** » Sat Jan 28, 2012 10:57 pm

I see you have taken the templates out. I have some pending changes that I need to fully test, but they save around 1130 bytes. Knocking out the templates saves about 1890 bytes.
Summary of pending changes:
Have a byte in strings that moves to a specified x position, e.g. "A\006B" displays 'A', moves to 6*FW then displays 'B'.
Make TITLEP() a procedure not a define, this saves quite a bit.
Improve the calculation of the offset in RADIO SETUP for the switch warning option.
Tidy up the switch warning ALERT, mainly by re-using get_switches_string() to save repeating all the strings in flash.

I'll keep looking for some more savings. I need to look at the FrSky bits, they are using up quite a bit.

Erazz, do we want to have the ersky9x sources completely separate, or is it worth trying to keep some sources the same, then enhancements happen to both at the same time? I realise this might get more difficult as ersky9x will get more enhancements as time goes on.

Mike.

capitaineflam25 · Post by **capitaineflam25** » Sat Jan 28, 2012 11:15 pm

Templates are great ... on eepe. No problem for me to have them off er9x.

Is there any possibility on the forum to open a poll to confirm that ?

Post by **erazz** » Sun Jan 29, 2012 2:08 am

Yeah, the FrSky version is gettign porkey

Anything you can save is great. I don't think we're done with the additions.

Concerning ERSKY9x, the code and concepts should be kept separate. For example, there is no real reason to have a bona-fida file system. You can simply divide the memory up into "slots" and still have hundreds of models to save. ERSKY9x has a lot more potential because of the horsepower, that's why I think it's best to keep them separate.

Soon enough I'll get myself sorted out on ERSKY and start pushing changes of my own

openrcforums