FUNC switches bug?

openTx has introduced a range of new features, ideas and bling. It is fast becoming the firmware of choice for many users. openTx will run on ALL current hardware platforms, including the gruvin9x and sky9x boards. Work has already started to support the new FrSky X9D radio!
Post Reply
User avatar
Kilrah
Posts: 11109
Joined: Sat Feb 18, 2012 6:56 pm
Country: Switzerland

FUNC switches bug?

Post by Kilrah »

Today I wanted to set a func switch for something, and got an unwanted motor start (nothing bad) with r766.

Let's say you have the first FUNC switch set as Security CH1 with -100, everything's fine.
Now you want to set another switch for something else. You go to the appropriate screen, and scroll down to go to the 2nd func switch line.
But, when you go over the first line's switch selector while doing so, that line gets deactivated for as long as you stay on it.

So if you have a the throttle stick at 30%, and scroll over the switch selection item for the throttle security switch, the motor will start.

bertrand35
9x Developer
Posts: 2764
Joined: Fri Dec 30, 2011 11:11 pm
Country: -

Re: FUNC switches bug?

Post by bertrand35 »

Working on it right now. There will be a ON / OFF option for this function. This is the only solution I can see to be safe.
Bertrand.
Attachments
snapshot_04.png
snapshot_04.png (1003 Bytes) Viewed 5803 times
User avatar
MikeB
9x Developer
Posts: 17993
Joined: Tue Dec 27, 2011 1:24 pm
Country: -
Location: Poole, Dorset, UK

Re: FUNC switches bug?

Post by MikeB »

Just a thought anyway, Use the LAST function switch for the throttle safety, then you won't step past it to get to another, just another small safety measure.

Mike.
erskyTx/er9x developer
The difficult we do immediately,
The impossible takes a little longer!
User avatar
Kilrah
Posts: 11109
Joined: Sat Feb 18, 2012 6:56 pm
Country: Switzerland

Re: FUNC switches bug?

Post by Kilrah »

Unless you press UP when on the screen (and it wraps around). And by setting it on the last line, it won't appear to be there as the screen is 2 pages long...
User avatar
MikeB
9x Developer
Posts: 17993
Joined: Tue Dec 27, 2011 1:24 pm
Country: -
Location: Poole, Dorset, UK

Re: FUNC switches bug?

Post by MikeB »

Why does it get de-activated in the first place. Er9x doesn't de-activate a safety switch while stepping over it, even in the latest version where it could be assigned to an alarm function.

Mike.
erskyTx/er9x developer
The difficult we do immediately,
The impossible takes a little longer!

User avatar
Kilrah
Posts: 11109
Joined: Sat Feb 18, 2012 6:56 pm
Country: Switzerland

Re: FUNC switches bug?

Post by Kilrah »

Because of the opposite problem - When you select an empty func switch and change the switch selector, the function instantly changes to "Security CH1" with a default setting of 0. If your model is on at this point and you step over an active switch, your motor starts before you get to adjust to -100.
So that's why it was changed to "make it effective only when you have finished setting everything and leave the line".
User avatar
MikeB
9x Developer
Posts: 17993
Joined: Tue Dec 27, 2011 1:24 pm
Country: -
Location: Poole, Dorset, UK

Re: FUNC switches bug?

Post by MikeB »

So, for a safety switch, you should set the value setting before selecting the switch, I might just change the order of the items on the display, so the value is in the middle, and the switch selection is on the right. At least that way the user is prompted to change the value before choosing the switch.

Mike.
erskyTx/er9x developer
The difficult we do immediately,
The impossible takes a little longer!
User avatar
Kilrah
Posts: 11109
Joined: Sat Feb 18, 2012 6:56 pm
Country: Switzerland

Re: FUNC switches bug?

Post by Kilrah »

Yeah, sounds good for er9x.

On open9x the handling is different, Safety switches don't have their own page, and are rather choices in the "Func Switches" page. But there you can't select the function or value before you choose the switch.

The on/off item seems very safe indeed, although takes eeprom and complicates things a bit you really can't miss it.
bertrand35
9x Developer
Posts: 2764
Joined: Fri Dec 30, 2011 11:11 pm
Country: -

Re: FUNC switches bug?

Post by bertrand35 »

It takes far less EEPROM than having one value + one switch per output. And less flash also, we don't need a screen just for it! Someone proposed me a checkbox instead of ON / OFF. I will give a try for next version. Perhaps will use too much flash and it will be available only for the V4 and ARM boards.
Bertrand.
User avatar
mhotar
Posts: 198
Joined: Wed May 16, 2012 9:57 pm
Country: -
Location: Jemnice, Vysocina

Re: FUNC switches bug?

Post by mhotar »

Can you reuse trim graphics for checkbox?
bertrand35
9x Developer
Posts: 2764
Joined: Fri Dec 30, 2011 11:11 pm
Country: -

Re: FUNC switches bug?

Post by bertrand35 »

I have a function for rectangles with round corners (the ROUND attribute). Would you post here a bitmap?
Bertrand.

Post Reply

Return to “openTx”