ongoing eepe issue

[Crucial]

I posted about a problem in eepe with downloading the er9x and nmea versions around August. post here viewtopic.php?f=5&t=1396#p20084

Someone else just posted on rcgroups about the same issue. I'v looked through the code on the google code page and found something that might have caused this issue. I'll try and post the code differences here.

The change happened here. http://code.google.com/p/eepe/source/di ... window.cpp

The section

Code: Select all

void MainWindow::downloadLatester9x()
{

    QSettings settings("er9x-eePe", "eePe");

    QString dnldURL, baseFileName;
    switch (settings.value("download-version", 0).toInt())
    {
    case (DNLD_VER_ER9X_JETI):
        dnldURL = ER9X_JETI_URL;
        baseFileName = "er9x-jeti.hex";
        break;
    case (DNLD_VER_ER9X_FRSKY):
        dnldURL = ER9X_FRSKY_URL;
        baseFileName = "er9x-frsky.hex";
        break;
    case (DNLD_VER_ER9X_ARDUPILOT):
        dnldURL = ER9X_ARDUPILOT_URL;
        baseFileName = "er9x-ardupilot.hex";
        break;
    case (DNLD_VER_ER9X_FRSKY_NOHT):
        dnldURL = ER9X_FRSKY_NOHT_URL;
        baseFileName = "er9x-frsky-noht.hex";
        break;
    case (DNLD_VER_ER9X_NOHT):
        dnldURL = ER9X_NOHT_URL;
        baseFileName = "er9x-noht.hex";
        break;
    default:
        dnldURL = ER9X_URL;
        baseFileName = "er9x.hex";
        break;
    }

Was replaced with this

Code: Select all

void MainWindow::downloadLatester9x()
{

    QSettings settings("er9x-eePe", "eePe");

    QString dnldURL, baseFileName;
    switch (settings.value("download-version", 0).toInt())
    {
    case (DNLD_VER_ER9X_JETI):
        dnldURL = ER9X_JETI_URL;
        baseFileName = "er9x-jeti.hex";
        break;
    case (DNLD_VER_ER9X_FRSKY):
        dnldURL = ER9X_FRSKY_URL;
        baseFileName = "er9x-frsky.hex";
        break;
    case (DNLD_VER_ER9X_ARDUPILOT):
        dnldURL = ER9X_ARDUPILOT_URL;
        baseFileName = "er9x-ardupilot.hex";
        break;
    case (DNLD_VER_ER9X_NMEA):
        dnldURL = ER9X_NMEA_URL;
        baseFileName = "er9x-nmea.hex";
        break;
    case (DNLD_VER_ER9X_FRSKY_NOHT):
        dnldURL = ER9X_FRSKY_NOHT_URL;
        baseFileName = "er9x-frsky-noht.hex";
        break;
    case (DNLD_VER_ER9X_NOHT):
        dnldURL = ER9X_NOHT_URL;
        baseFileName = "er9x-noht.hex";
        break;

    case (DNLD_VER_ER9X_SPKR):
        dnldURL = ER9X_SPKR_URL;
        baseFileName = "er9x-spkr.hex";
        break;
    case (DNLD_VER_ER9X_NOHT_SPKR):
        dnldURL = ER9X_NOHT_SPKR_URL;
        baseFileName = "er9x-noht-spkr.hex";
        break;
    case (DNLD_VER_ER9X_FRSKY_SPKR):
        dnldURL = ER9X_FRSKY_SPKR_URL;
        baseFileName = "er9x-frsky-spkr.hex";
        break;
    case (DNLD_VER_ER9X_FRSKY_NOHT_SPKR):
        dnldURL = ER9X_FRSKY_NOHT_SPKR_URL;
        baseFileName = "er9x-frsky-noht-spkr.hex";
        break;
    }

The block of text referencing the default download was removed and was never replaced
default:
dnldURL = ER9X_URL;
baseFileName = "er9x.hex";

This was done at the same time the speaker and nmea versions were added. Is this a possible solution to the before mentioned problem of downloading er9x.hex and er9x-nmea.hex

I don't know how to compile eepe otherwise I would just add the text back and try it.

[gohsthb]

The current version (r351) has the default option back in.
-Gohst

[MikeB]

To comopile eepe, you need to get a copy of QtCreator. This is a complete IDE and compiler.

Have a look at:
http://qt.nokia.com/products/developer-tools/

Mike.

[Crucial]

downloading the qt installer now. It's not a very fast connection so I will hopefully get a chance to try it later tonight.

[Crucial]

Success! I made 2 changes to the code and ran the program from within QTCreator and the problem is fixed. Now I need to know how to get those changes to whoever can test them and commit it to another version. I assume Mike or Erazz.

[MikeB]

PM me the changes, a SVN diff file will do, or the whole files you have changed, I'll get them committed. At present I need Erazz to do the build and release, I need to find time to see if I can do a build, but at least Erazz does a cross check of my changes.
Of course, you could become a committer and update eepe directly, we need some help

Mike.

[Crucial]

I'm afraid I need to become a lot more familiar with this before trying to start updating eepe. My crash course in svn and how to use qt just barely got me this far.

All the changes were in mainwindow.cpp

I'm just glad I could give back a little bit.

[MikeB]

I'm still working out how to use QtCreator. At least you can do the odd change, hit the 'RUN' button and see if it works. If you don't like the change, just do a svn revert to go back.

I'll commit your change, with my latest later today, or tomorrow.

Mike.