eepskye 405 crashes on Edit

[sdavies]

I have just rebuilt eepskye 405 (with stamp file that says 402) on my Fedora 21 box.
The build was straight forward and the program starts up OK.

However, if I do File New and then double click on an empty slot, it crashes with:

A layout can only have another layout as a parent.

Also, if I try to drag and drop from eepe, I get:

Can't paste from er9x file.

I read in another post that this was supposed to work.

QT version is 4.8.6

[MikeB]

On windows, I'm running 4.7.4. For linux, I run a virtual box and have 5.0.2 there.
Both build and run OK, and someone else has built a MAC version that runs OK.

I'll try to do a bulid on linux later today.
I actually need to get the source files committed, and with googlecode closing I'm going to have a bit of a headache getting everything transferred over to Github.

Mike.

[MikeB]

I've just committed all the source files as I currently have them. Please try building again.

Mike.

[sdavies]

Just tried to rebuild but:

modeledit.cpp:9:30: fatal error: VoiceAlarmDialog.h: No such file or directory
#include "VoiceAlarmDialog.h"
^
compilation terminated.
Makefile:540: recipe for target 'modeledit.o' failed
make: *** [modeledit.o] Error 1
[scldad@mustang src]$ find .. -name VoiceAlarmDialog.h -print
[scldad@mustang src]$ cd eepskye/src
[scldad@mustang src]$ qmake-qt4 eepskye.pro
WARNING: Failure to find: VoiceAlarmDialog.cpp
WARNING: Failure to find: VoiceAlarmDialog.h
WARNING: Failure to find: VoiceAlarmDialog.ui

No sign of any VoiceAlarmDialog* in this or previous checkout.
Cheers,
Stephen

[MikeB]

I just added the missing files.

Mike.

[sdavies]

Redid the checkout for the new files.

Tried eepe first.
First result:

g++ -c -pipe -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -O2 -Wall -W -D_REENTRANT -DQESP_NO_UDEV -D__linux__ -DQT_NO_DEBUG -DQT_XML_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/lib64/qt4/mkspecs/linux-g++ -I. -I/usr/include/QtCore -I/usr/include/QtNetwork -I/usr/include/QtGui -I/usr/include/QtXml -I/usr/include -I. -I. -I. -o modeledit.o modeledit.cpp
modeledit.cpp:9:30: fatal error: VoiceAlarmDialog.h: No such file or directory
#include "VoiceAlarmDialog.h"
^
compilation terminated.
Makefile:540: recipe for target 'modeledit.o' failed
make: *** [modeledit.o] Error 1

so I copied VoiceAlarmDialog.h from the eepskye/src directory to the eepe/src directory.
This gave:


g++ -c -pipe -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -O2 -Wall -W -D_REENTRANT -DQESP_NO_UDEV -D__linux__ -DQT_NO_DEBUG -DQT_XML_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/lib64/qt4/mkspecs/linux-g++ -I. -I/usr/include/QtCore -I/usr/include/QtNetwork -I/usr/include/QtGui -I/usr/include/QtXml -I/usr/include -I. -I. -I. -o modeledit.o modeledit.cpp
In file included from modeledit.cpp:9:0:
VoiceAlarmDialog.h:15:104: error: ‘SKYModelData’ has not been declared
VoiceAlarmDialog(QWidget *parent, VoiceAlarmData *invad, int eeType, int stickmode, int modelVersion, SKYModelData *pModel ) ;
^
In file included from modeledit.cpp:9:0:
VoiceAlarmDialog.h:31:2: error: ‘SKYModelData’ does not name a type
SKYModelData *lpModel ;
^
modeledit.cpp:282:59: warning: unused parameter ‘states’ [-Wunused-parameter]
uint16_t ModelEdit::oneSwitchPos( uint8_t swtch, uint16_t states )
^
modeledit.cpp: In member function ‘void ModelEdit::on_VoiceAlarmList_doubleClicked(QModelIndex)’:
modeledit.cpp:4298:154: error: no matching function for call to ‘VoiceAlarmDialog::VoiceAlarmDialog(ModelEdit*, VoiceAlarmData*, uint8_t&, uint8_t&, uint8_t&, ModelData*)’
VoiceAlarmDialog *dlg = new VoiceAlarmDialog( this, &g_model.vad[index.row()], eeFile->mee_type, g_eeGeneral.stickMode, g_model.modelVersion, &g_model ) ;
^
modeledit.cpp:4298:154: note: candidates are:
In file included from modeledit.cpp:9:0:
VoiceAlarmDialog.h:15:2: note: VoiceAlarmDialog::VoiceAlarmDialog(QWidget*, VoiceAlarmData*, int, int, int, int*)
VoiceAlarmDialog(QWidget *parent, VoiceAlarmData *invad, int eeType, int stickmode, int modelVersion, SKYModelData *pModel ) ;
^
VoiceAlarmDialog.h:15:2: note: no known conversion for argument 6 from ‘ModelData* {aka t_ModelData*}’ to ‘int*’
In file included from modeledit.cpp:9:0:
VoiceAlarmDialog.h:12:7: note: VoiceAlarmDialog::VoiceAlarmDialog(const VoiceAlarmDialog&)
class VoiceAlarmDialog : public QDialog {
^

Then I tried eepskye but got:

VoiceAlarmDialog.h:12:7: note: candidate expects 1 argument, 6 provided
Makefile:540: recipe for target 'modeledit.o' failed
make: *** [modeledit.o] Error 1


g++ -c -pipe -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -O2 -Wall -W -D_REENTRANT -DSKY=1 -DQESP_NO_UDEV -D__linux__ -DQT_NO_DEBUG -DQT_XML_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/lib64/qt4/mkspecs/linux-g++ -I. -I/usr/include/QtCore -I/usr/include/QtNetwork -I/usr/include/QtGui -I/usr/include/QtXml -I/usr/include -I../../../src -I. -I. -o moc_qextserialport.o moc_qextserialport.cpp
moc_qextserialport.cpp: In static member function ‘static void QextSerialPort::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)’:
moc_qextserialport.cpp:96:30: error: invalid use of incomplete type ‘class QextSerialPortPrivate’
case 13: _t->d_func()->_q_canRead(); break;
^
In file included from moc_qextserialport.cpp:9:0:
../../qextserialport.h:167:7: error: forward declaration of ‘class QextSerialPortPrivate’
class QextSerialPortPrivate;
^
Makefile:699: recipe for target 'moc_qextserialport.o' failed
make: *** [moc_qextserialport.o] Error 1

I have seen this error before but still don't understand it.

Cheers,
Stephen

[MikeB]

I've committed the voicealarm files for eepe as well now.
Please try again. There may be some problems due to the different versions of QT.

Mike.

[sdavies]

I reran the checkout and got V408.
The initial rebuild of eepe gave a bunch of errors in serialdialog.cpp due to uint8_t not being defined.
I took the "big stick" approach and added
#include <stdint.h>
to the start of serialdialog.h.
This then gave:
g++ -Wl,-O1 -Wl,-z,relro -o eepe qextserialport.o qextserialenumerator.o qextserialport_unix.o qextserialenumerator_linux.o main.o mainwindow.o file.o pers.o modeledit.o generaledit.o mdichild.o helpers.o node.o edge.o mixerdialog.o burnconfigdialog.o avroutputdialog.o simulatordialog.o donatorsdialog.o printdialog.o preferencesdialog.o mixerslist.o downloaddialog.o customizesplashdialog.o serialdialog.o telemetry.o reviewOutput.o moc_mainwindow.o moc_modeledit.o moc_generaledit.o moc_mdichild.o moc_mixerdialog.o moc_burnconfigdialog.o moc_avroutputdialog.o moc_simulatordialog.o moc_donatorsdialog.o moc_printdialog.o moc_preferencesdialog.o moc_mixerslist.o moc_downloaddialog.o moc_customizesplashdialog.o moc_serialdialog.o moc_telemetry.o moc_reviewOutput.o qrc_eepe.o -L/usr/lib64 -lQtXml -lQtGui -lQtNetwork -lQtCore -lpthread
modeledit.o: In function `ModelEdit::on_VoiceAlarmList_doubleClicked(QModelIndex)':
/var/sources/eepe/src/modeledit.cpp:4298: undefined reference to `VoiceAlarmDialog::VoiceAlarmDialog(QWidget*, t_voiceAlarm*, int, int, int, t_ModelData*)'
collect2: error: ld returned 1 exit status
Makefile:192: recipe for target 'eepe' failed

eepskye failed as before with the "forward declaration" error.

I then upgraded my Qt to V5.4.0 and tried it all again.
eepe now gives hundreds of errors like:
mainwindow.cpp:1650:285: error: request for member ‘control’ in ‘_container_’, which is of non-class type ‘int’
foreach (QMdiSubWindow *window, mdiArea->subWindowList()) {
^
mainwindow.cpp:1651:61: error: invalid use of incomplete type ‘class QMdiSubWindow’
MdiChild *mdiChild = qobject_cast<MdiChild *>(window->widget());
^
In file included from mainwindow.cpp:49:0:
mainwindow.h:56:7: error: forward declaration of ‘class QMdiSubWindow’
class QMdiSubWindow;
^
mainwindow.cpp: In member function ‘void MainWindow::setActiveSubWindow(QWidget*)’:
mainwindow.cpp:1670:12: error: invalid use of incomplete type ‘class QMdiArea’
mdiArea->setActiveSubWindow(qobject_cast<QMdiSubWindow *>(window));
^
In file included from mainwindow.cpp:49:0:
mainwindow.h:55:7: error: forward declaration of ‘class QMdiArea’
class QMdiArea;
^
In file included from /usr/include/qt5/QtCore/qobject.h:40:0,
from /usr/include/qt5/QtCore/qabstractanimation.h:37,
from /usr/include/qt5/QtCore/QtCore:4,
from /usr/include/qt5/QtGui/QtGuiDepends:3,
from /usr/include/qt5/QtGui/QtGui:3,
from mainwindow.cpp:42:
/usr/include/qt5/QtCore/qobjectdefs.h: In instantiation of ‘struct QtPrivate::HasQ_OBJECT_Macro<QMdiSubWindow>’:
/usr/include/qt5/QtCore/qobject.h:518:67: required from ‘T qobject_cast(QObject*) [with T = QMdiSubWindow*]’
mainwindow.cpp:1670:69: required from here
/usr/include/qt5/QtCore/qobjectdefs.h:485:36: error: incomplete type ‘QMdiSubWindow’ used in nested name specifier
enum { Value = sizeof(test(&Object::qt_metacall)) == sizeof(int) };
^
In file included from /usr/include/qt5/QtCore/qabstractanimation.h:37:0,
from /usr/include/qt5/QtCore/QtCore:4,
from /usr/include/qt5/QtGui/QtGuiDepends:3,
from /usr/include/qt5/QtGui/QtGui:3,
from mainwindow.cpp:42:
/usr/include/qt5/QtCore/qobject.h: In instantiation of ‘T qobject_cast(QObject*) [with T = QMdiSubWindow*]’:
mainwindow.cpp:1670:69: required from here
/usr/include/qt5/QtCore/qobject.h:518:44: error: invalid application of ‘sizeof’ to incomplete type ‘QStaticAssertFailure<false>’
Q_STATIC_ASSERT_X(QtPrivate::HasQ_OBJECT_Macro<ObjType>::Value,
^
/usr/include/qt5/QtCore/qobject.h:520:65: error: incomplete type ‘ObjType {aka QMdiSubWindow}’ used in nested name specifier
return static_cast<T>(ObjType::staticMetaObject.cast(object));
^
Makefile:679: recipe for target 'mainwindow.o' failed
make: *** [mainwindow.o] Error 1

eepskye gives similar errors:

mainwindow.cpp:1641:121: error: request for member ‘control’ in ‘_container_’, which is of non-class type ‘int’
foreach (QMdiSubWindow *window, mdiArea->subWindowList()) {
^
mainwindow.cpp:1641:144: error: request for member ‘i’ in ‘_container_’, which is of non-class type ‘int’
foreach (QMdiSubWindow *window, mdiArea->subWindowList()) {
^
mainwindow.cpp:1641:161: error: request for member ‘e’ in ‘_container_’, which is of non-class type ‘int’
foreach (QMdiSubWindow *window, mdiArea->subWindowList()) {
^
mainwindow.cpp:1641:178: error: request for member ‘i’ in ‘_container_’, which is of non-class type ‘int’
foreach (QMdiSubWindow *window, mdiArea->subWindowList()) {
^
mainwindow.cpp:1641:193: error: request for member ‘control’ in ‘_container_’, which is of non-class type ‘int’
foreach (QMdiSubWindow *window, mdiArea->subWindowList()) {
^
mainwindow.cpp:1641:249: error: request for member ‘i’ in ‘_container_’, which is of non-class type ‘int’
foreach (QMdiSubWindow *window, mdiArea->subWindowList()) {
^
mainwindow.cpp:1641:264: error: request for member ‘control’ in ‘_container_’, which is of non-class type ‘int’
foreach (QMdiSubWindow *window, mdiArea->subWindowList()) {
^
mainwindow.cpp:1641:285: error: request for member ‘control’ in ‘_container_’, which is of non-class type ‘int’
foreach (QMdiSubWindow *window, mdiArea->subWindowList()) {
^
mainwindow.cpp:1642:61: error: invalid use of incomplete type ‘class QMdiSubWindow’
MdiChild *mdiChild = qobject_cast<MdiChild *>(window->widget());
^
In file included from mainwindow.cpp:50:0:
mainwindow.h:56:7: error: forward declaration of ‘class QMdiSubWindow’
class QMdiSubWindow;
^
mainwindow.cpp: In member function ‘void MainWindow::setActiveSubWindow(QWidget*)’:
mainwindow.cpp:1661:12: error: invalid use of incomplete type ‘class QMdiArea’
mdiArea->setActiveSubWindow(qobject_cast<QMdiSubWindow *>(window));
^
In file included from mainwindow.cpp:50:0:
mainwindow.h:55:7: error: forward declaration of ‘class QMdiArea’
class QMdiArea;
^
In file included from /usr/include/qt5/QtCore/qobject.h:40:0,
from /usr/include/qt5/QtCore/qabstractanimation.h:37,
from /usr/include/qt5/QtCore/QtCore:4,
from /usr/include/qt5/QtGui/QtGuiDepends:3,
from /usr/include/qt5/QtGui/QtGui:3,
from mainwindow.cpp:42:
/usr/include/qt5/QtCore/qobjectdefs.h: In instantiation of ‘struct QtPrivate::HasQ_OBJECT_Macro<QMdiSubWindow>’:
/usr/include/qt5/QtCore/qobject.h:518:67: required from ‘T qobject_cast(QObject*) [with T = QMdiSubWindow*]’
mainwindow.cpp:1661:69: required from here
/usr/include/qt5/QtCore/qobjectdefs.h:485:36: error: incomplete type ‘QMdiSubWindow’ used in nested name specifier
enum { Value = sizeof(test(&Object::qt_metacall)) == sizeof(int) };
^
In file included from /usr/include/qt5/QtCore/qabstractanimation.h:37:0,
from /usr/include/qt5/QtCore/QtCore:4,
from /usr/include/qt5/QtGui/QtGuiDepends:3,
from /usr/include/qt5/QtGui/QtGui:3,
from mainwindow.cpp:42:
/usr/include/qt5/QtCore/qobject.h: In instantiation of ‘T qobject_cast(QObject*) [with T = QMdiSubWindow*]’:
mainwindow.cpp:1661:69: required from here
/usr/include/qt5/QtCore/qobject.h:518:44: error: invalid application of ‘sizeof’ to incomplete type ‘QStaticAssertFailure<false>’
Q_STATIC_ASSERT_X(QtPrivate::HasQ_OBJECT_Macro<ObjType>::Value,
^
/usr/include/qt5/QtCore/qobject.h:520:65: error: incomplete type ‘ObjType {aka QMdiSubWindow}’ used in nested name specifier
return static_cast<T>(ObjType::staticMetaObject.cast(object));
^
Makefile:690: recipe for target 'mainwindow.o' failed
make: *** [mainwindow.o] Error 1

[MikeB]

I think this has to be QT changing things between releases.
For me to investigate I'll probably need to update my versions of QT (Windows and Linux).
I'll see what I can do, but I've also got to migrate the source code to Github from googlecode because googlecode is closing down.

Mike.

[sdavies]

Qt changes are a nuisance (and I have deleted Qt 5) but I suspect that the 4.8 errors are not Qt.

The uint8_t, VoiceAlarmDialog and forward declaration issues look more like C++ or coding .

The 405 versions of eepe and eepskye built on my box without any problems and eepe 405 works as expected. It was only the 405 version of eepskye that crashed on Edit.

The googlecode shutdown is a bummer even though it is 12 months out. I am also involved in the gawk project which moved to git a while back.
Overall, I think I prefer git to svn.

On a tangent, is the drag-and-drop from eepe to eepskye supposed to work as suggested in one of the forums?

Cheers,
Stephen

[MikeB]

Just checking my serialdialog.cpp, it has a line:
#include <inttypes.h>
at the top. This header includes:
#include <sys/stdint.h>

On my setup.

Mike.

[MikeB]

I'm running Qt 5.0.2 in my linux virtual box and I did get the uint8_t errors. I've changed them to unsigned char and then things build OK.
I've comitted the source file changes.

I've just posted the built executables for eepe and eepskye for both Windows and linux here:
viewtopic.php?f=7&t=4676#p65894

Mike.

[sdavies]

I downloaded your binaries and the first thing I see is that they are 32-bit binaries.
I am trying to build on a 64-bit Fedora 21 box.
I tried installing the 32-bit Qt libraries but so far without success.
Any chance of your doing a 64-bit build?
Cheers and thanks,
Stephen

[sdavies]

Found another laptop with F21 and 32-bit Qt installed and tried your binaries there.
Both seem to work but both gave errors regarding pk-gtk-module, canberra-gtk-module and theme engine adwaita.
I fixed the first by installing Packagekit-gtk3-module.i686 but haven't yet been able to fix the other two.

Both eepe and eepskye seem to work well despite the errors, thank you.

When I tried the drag-and-drop from eepe to eepskye, it said "partial save".
Where can I read more about this?

My gotcha now is that I can run your binaries but I can't build 32-bit versions (no tools) nor 64-bit versions (build errors).

[sdavies]

I found the missing bits. Both are GTK 2 rather than 3.
Still no joy with builds: same errors as before.

[MikeB]

My linux virtual box is 32-bit, I'm not sure if I can build a 64-bit binary on there. I'm not that familiar with the possibilities with QT, I've just taken the original code from Erazz and updated it. I even had to get him to build for linux to start with, and I still rely on someone else to build MAC versions.

Mike.

[jhsa]

But a 32 bit also runs on a 64 bit machine, right? I do apologize but I can't see where the problem is then..

João

[Suncoaster]

But a 32 bit also runs on a 64 bit machine, right? I do apologize but I can't see where the problem is then..

João

That is true I run the program on my 64 bit Linux Mint 17.1. I start the program from a terminal session and apart from the error listed below

(eepskye:3518): Gtk-CRITICAL **: IA__gtk_widget_get_direction: assertion 'GTK_IS_WIDGET (widget)' failed

the program seems to work fine.

Dave

[jhsa]

Then, do we really need a 64 bit version? Sorry about the questions, I ask because I don't really know.

João

[Suncoaster]

As far as I am concerned the answer is no, but others may have a different opinion.

Dave

[jhsa]

Of course. Thanks for your answer..

João

[sdavies]

I eventually managed to get 32-bit Qt to coexist with 64-bit Qt on one box but cannot get yum to do it on another.
I can run Mike's 32-bit binaries on the first box so I can survive.

The thing that puzzles me most is why the same code builds OK as 32-bit but fails with C++ errors as 64-bit.
Qt and C++ are supposed to be the same on both.

I would prefer to be able to build my own binaries so that I know I am up-to-date without having to ask Mike.

[MikeB]

I've had a look, but I think I'm going to have to create another virtual box with a 64-bit version of linux in it, along with QT for 64-bit to be able to investigate further.

Mike.